diff --git a/examples/endpoint/error.zig b/examples/endpoint/error.zig index 255c936..3e5ee2f 100644 --- a/examples/endpoint/error.zig +++ b/examples/endpoint/error.zig @@ -7,9 +7,7 @@ pub const ErrorEndpoint = @This(); path: []const u8 = "/error", error_strategy: zap.Endpoint.ErrorStrategy = .log_to_response, -pub fn get(e: *ErrorEndpoint, r: zap.Request) !void { - _ = e; - _ = r; +pub fn get(_: *ErrorEndpoint, _: zap.Request) !void { return error.@"Oh-no!"; } diff --git a/examples/endpoint/stopendpoint.zig b/examples/endpoint/stopendpoint.zig index 0e5d067..2b12bd6 100644 --- a/examples/endpoint/stopendpoint.zig +++ b/examples/endpoint/stopendpoint.zig @@ -14,9 +14,7 @@ pub fn init(path: []const u8) StopEndpoint { }; } -pub fn get(e: *StopEndpoint, r: zap.Request) !void { - _ = e; - _ = r; +pub fn get(_: *StopEndpoint, _: zap.Request) !void { zap.stop(); } diff --git a/examples/websockets/websockets.zig b/examples/websockets/websockets.zig index 97ec250..e2d9f31 100644 --- a/examples/websockets/websockets.zig +++ b/examples/websockets/websockets.zig @@ -125,8 +125,9 @@ fn handle_websocket_message( message: []const u8, is_text: bool, ) void { - _ = is_text; _ = handle; + _ = is_text; + if (context) |ctx| { // send message const buflen = 128; // arbitrary len diff --git a/src/endpoint.zig b/src/endpoint.zig index ae67fbc..6a06093 100644 --- a/src/endpoint.zig +++ b/src/endpoint.zig @@ -43,9 +43,7 @@ //! pub fn patch(_: *StopEndpoint, _: zap.Request) void {} //! pub fn options(_: *StopEndpoint, _: zap.Request) void {} //! -//! pub fn get(self: *StopEndpoint, r: zap.Request) void { -//! _ = self; -//! _ = r; +//! pub fn get(_: *StopEndpoint, _: zap.Request) void { //! zap.stop(); //! } //! }; diff --git a/src/router.zig b/src/router.zig index ff35831..61223e4 100644 --- a/src/router.zig +++ b/src/router.zig @@ -63,8 +63,7 @@ pub fn handle_func_unbound(self: *Router, path: []const u8, h: zap.HttpRequestFn /// /// ```zig /// const HandlerType = struct { -/// pub fn getA(self: *HandlerType, r: zap.Request) void { -/// _ = self; +/// pub fn getA(_: *HandlerType, r: zap.Request) void { /// r.sendBody("hello\n\n") catch return; /// } /// } diff --git a/src/tests/test_auth.zig b/src/tests/test_auth.zig index 1dba9a1..a660b04 100644 --- a/src/tests/test_auth.zig +++ b/src/tests/test_auth.zig @@ -151,16 +151,14 @@ pub const Endpoint = struct { path: []const u8, error_strategy: zap.Endpoint.ErrorStrategy = .raise, - pub fn get(e: *Endpoint, r: zap.Request) !void { - _ = e; + pub fn get(_: *Endpoint, r: zap.Request) !void { r.sendBody(HTTP_RESPONSE) catch return; received_response = HTTP_RESPONSE; std.time.sleep(1 * std.time.ns_per_s); zap.stop(); } - pub fn unauthorized(e: *Endpoint, r: zap.Request) !void { - _ = e; + pub fn unauthorized(_: *Endpoint, r: zap.Request) !void { r.setStatus(.unauthorized); r.sendBody("UNAUTHORIZED ACCESS") catch return; received_response = "UNAUTHORIZED"; @@ -590,6 +588,8 @@ test "BasicAuth UserPass authenticateRequest test-unauthorized" { var encoder = std.base64.url_safe.Encoder; var buffer: [256]u8 = undefined; const encoded = encoder.encode(&buffer, token); + + // not interested in the encoded auth string; we want unauthorized _ = encoded; // create authenticator