mirrors/zig
1
0
Fork 0
mirror of https://codeberg.org/ziglang/zig.git synced 2025-12-06 13:54:21 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

isHex, isAlphanumeric: prong reorder

Browse source 
On x86 interestingly I can see a reduction in codesize by 1 instruction with this.
While not necessarily faster, it might still reduce codesize a bit and this ordering is also more logical
because it follows ASCII table order. Rust's std uses this ordering too.
See https://zig.godbolt.org/z/PqodY8YqY for the difference.
This commit is contained in:
r00ster91 2022-11-01 18:26:04 +01:00
parent 19dbc5805c
commit 0162a0868c
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
lib/std/ascii.zig
View file

@ -91,7 +91,7 @@ pub const control_code = struct {
/// Returns whether the character is alphanumeric: A-Z, a-z, or 0-9. /// Returns whether the character is alphanumeric: A-Z, a-z, or 0-9.
pub fn isAlphanumeric(c: u8) bool { pub fn isAlphanumeric(c: u8) bool {
return switch (c) { return switch (c) {
'A'...'Z', 'a'...'z', '0'...'9' => true, '0'...'9', 'A'...'Z', 'a'...'z' => true,
else => false, else => false,
}; };
} }
@ -167,7 +167,7 @@ pub fn isUpper(c: u8) bool {
/// Returns whether the character is a hexadecimal digit: A-F, a-f, or 0-9. /// Returns whether the character is a hexadecimal digit: A-F, a-f, or 0-9.
pub fn isHex(c: u8) bool { pub fn isHex(c: u8) bool {
return switch (c) { return switch (c) {
'A'...'F', 'a'...'f', '0'...'9' => true, '0'...'9', 'A'...'F', 'a'...'f' => true,
else => false, else => false,
}; };
} }