mirrors/zig
1
0
Fork 0
mirror of https://codeberg.org/ziglang/zig.git synced 2025-12-09 15:19:07 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

std.debug: never attempt FP unwind under fomit-frame-pointer

Browse source
This commit is contained in:
mlugg 2025-09-11 13:32:15 +01:00
parent 4e45362529
commit 02a0ade138
No known key found for this signature in database
GPG key ID: 3F5B7DCCBF4AF02E
1 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
lib/std/debug.zig
View file

@ -815,13 +815,17 @@ const StackIterator = union(enum) {
/// On aarch64-macos, Apple mandate that the frame pointer is always used. /// On aarch64-macos, Apple mandate that the frame pointer is always used.
/// TODO: are there any other architectures with guarantees like this? /// TODO: are there any other architectures with guarantees like this?
const fp_unwind_is_safe = !builtin.omit_frame_pointer and builtin.cpu.arch == .aarch64 and builtin.os.tag.isDarwin(); const fp_unwind_is_safe = builtin.cpu.arch == .aarch64 and builtin.os.tag.isDarwin();
/// Whether the current unwind strategy is allowed given `allow_unsafe`. /// Whether the current unwind strategy is allowed given `allow_unsafe`.
fn stratOk(it: *const StackIterator, allow_unsafe: bool) bool { fn stratOk(it: *const StackIterator, allow_unsafe: bool) bool {
return switch (it.*) { return switch (it.*) {
.di => true, .di => true,
.fp => allow_unsafe or fp_unwind_is_safe, // If we omitted frame pointers from *this* compilation, FP unwinding would crash
// immediately regardless of anything. But FPs could also be omitted from a different
// linked object, so it's not guaranteed to be safe, unless the target specifically
// requires it.
.fp => !builtin.omit_frame_pointer and (fp_unwind_is_safe or allow_unsafe),
}; };
} }