From 27f3e8b61db897f36c704c50c86c31b824297d30 Mon Sep 17 00:00:00 2001 From: mlugg Date: Wed, 26 Mar 2025 02:52:48 +0000 Subject: [PATCH] Zcu: include named tests in resolved references Oops, a little typo from yours truly! No test for this one, because we don't have any way of testing the reference trace. --- src/Zcu.zig | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/src/Zcu.zig b/src/Zcu.zig index 7e7bb6ce11..2623833246 100644 --- a/src/Zcu.zig +++ b/src/Zcu.zig @@ -3872,9 +3872,11 @@ fn resolveReferencesInner(zcu: *Zcu) !std.AutoHashMapUnmanaged(AnalUnit, ?Resolv .unnamed_test => true, .@"test", .decltest => a: { const fqn_slice = nav.fqn.toSlice(ip); - for (comp.test_filters) |test_filter| { - if (std.mem.indexOf(u8, fqn_slice, test_filter) != null) break; - } else break :a false; + if (comp.test_filters.len > 0) { + for (comp.test_filters) |test_filter| { + if (std.mem.indexOf(u8, fqn_slice, test_filter) != null) break; + } else break :a false; + } break :a true; }, }; @@ -3884,7 +3886,10 @@ fn resolveReferencesInner(zcu: *Zcu) !std.AutoHashMapUnmanaged(AnalUnit, ?Resolv @intFromEnum(inst_info.inst), }); try unit_queue.put(gpa, .wrap(.{ .nav_val = nav_id }), referencer); - try unit_queue.put(gpa, .wrap(.{ .func = nav.status.fully_resolved.val }), referencer); + // Non-fatal AstGen errors could mean this test decl failed + if (nav.status == .fully_resolved) { + try unit_queue.put(gpa, .wrap(.{ .func = nav.status.fully_resolved.val }), referencer); + } } } for (zcu.namespacePtr(ns).pub_decls.keys()) |nav| {