mirrors/zig
1
0
Fork 0
mirror of https://codeberg.org/ziglang/zig.git synced 2025-12-06 13:54:21 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

std.Thread.setName/getName: remove wrong error handling

Browse source 
std.posix.prctl already does error handling.
According to the man page PR_SET_NAME(2const), 0 is returned on success.
This commit is contained in:
rpkak 2025-11-28 17:26:43 +01:00
parent e19c61a16e
commit 6cb9a60def
No known key found for this signature in database
1 changed files with 4 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
lib/std/Thread.zig
View file

@ -189,11 +189,8 @@ pub fn setName(self: Thread, name: []const u8) SetNameError!void {
.linux => if (use_pthreads) { .linux => if (use_pthreads) {
if (self.getHandle() == std.c.pthread_self()) { if (self.getHandle() == std.c.pthread_self()) {
// Set the name of the calling thread (no thread id required). // Set the name of the calling thread (no thread id required).
const err = try posix.prctl(.SET_NAME, .{@intFromPtr(name_with_terminator.ptr)}); assert(try posix.prctl(.SET_NAME, .{@intFromPtr(name_with_terminator.ptr)}) == 0);
switch (@as(posix.E, @enumFromInt(err))) { return;
.SUCCESS => return,
else => |e| return posix.unexpectedErrno(e),
}
} else { } else {
const err = std.c.pthread_setname_np(self.getHandle(), name_with_terminator.ptr); const err = std.c.pthread_setname_np(self.getHandle(), name_with_terminator.ptr);
switch (@as(posix.E, @enumFromInt(err))) { switch (@as(posix.E, @enumFromInt(err))) {
@ -303,11 +300,8 @@ pub fn getName(self: Thread, buffer_ptr: *[max_name_len:0]u8) GetNameError!?[]co
.linux => if (use_pthreads) { .linux => if (use_pthreads) {
if (self.getHandle() == std.c.pthread_self()) { if (self.getHandle() == std.c.pthread_self()) {
// Get the name of the calling thread (no thread id required). // Get the name of the calling thread (no thread id required).
const err = try posix.prctl(.GET_NAME, .{@intFromPtr(buffer.ptr)}); assert(try posix.prctl(.GET_NAME, .{@intFromPtr(buffer.ptr)}) == 0);
switch (@as(posix.E, @enumFromInt(err))) { return std.mem.sliceTo(buffer, 0);
.SUCCESS => return std.mem.sliceTo(buffer, 0),
else => |e| return posix.unexpectedErrno(e),
}
} else { } else {
const err = std.c.pthread_getname_np(self.getHandle(), buffer.ptr, max_name_len + 1); const err = std.c.pthread_getname_np(self.getHandle(), buffer.ptr, max_name_len + 1);
switch (@as(posix.E, @enumFromInt(err))) { switch (@as(posix.E, @enumFromInt(err))) {