Merge pull request #17531 from moosichu/fix/frameworks

Fix some frameworks not linking macos
This commit is contained in:
Jakub Konka 2023-10-16 20:45:04 +02:00 committed by GitHub
commit 78f2ae7f29
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 13 additions and 2 deletions

View file

@ -707,6 +707,17 @@ fn accessLibPath(
return true;
}
noextension: {
test_path.clearRetainingCapacity();
try test_path.writer().print("{s}" ++ sep ++ "{s}", .{ search_dir, lib_name });
try checked_paths.append(try gpa.dupe(u8, test_path.items));
fs.cwd().access(test_path.items, .{}) catch |err| switch (err) {
error.FileNotFound => break :noextension,
else => |e| return e,
};
return true;
}
return false;
}

View file

@ -6956,9 +6956,9 @@ fn accessFrameworkPath(
) !bool {
const sep = fs.path.sep_str;
for (&[_][]const u8{ "tbd", "dylib" }) |ext| {
for (&[_][]const u8{ ".tbd", ".dylib", "" }) |ext| {
test_path.clearRetainingCapacity();
try test_path.writer().print("{s}" ++ sep ++ "{s}.framework" ++ sep ++ "{s}.{s}", .{
try test_path.writer().print("{s}" ++ sep ++ "{s}.framework" ++ sep ++ "{s}{s}", .{
framework_dir_path,
framework_name,
framework_name,