mirrors/zig
1
0
Fork 0
mirror of https://codeberg.org/ziglang/zig.git synced 2025-12-06 13:54:21 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

make crc32 a featdep of sse4.2

Browse source 
To my knowledge there isn't an implementation of `sse4.2` that doesn't have `crc32`.
The Clang driver also sets `crc32` to be implicitly enabled when an explicit `-crc32`
wasn't provided. This matches that behaviour.

We need this behaviour to compile libraries like `rocksdb` which currently guard against
`crc32` intrinsics by checking for `sse4.2`.
This commit is contained in:
David Rubin 2024-11-24 22:25:32 -08:00
parent bc3ed51b7f
commit 9e17e097e5
No known key found for this signature in database
GPG key ID: 2EBEA24BA674C720
2 changed files with 5 additions and 53 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

54
lib/std/Target/x86.zig
View file

@ -1162,6 +1162,7 @@ pub const all_features = blk: {
.llvm_name = "sse4.2", .llvm_name = "sse4.2",
.description = "Enable SSE 4.2 instructions", .description = "Enable SSE 4.2 instructions",
.dependencies = featureSet(&[_]Feature{ .dependencies = featureSet(&[_]Feature{
.crc32,
.sse4_1, .sse4_1,
}), }),
}; };
@ -1328,7 +1329,6 @@ pub const cpu = struct {
.clflushopt, .clflushopt,
.clwb, .clwb,
.cmov, .cmov,
.crc32,
.cx16, .cx16,
.f16c, .f16c,
.false_deps_perm, .false_deps_perm,
@ -1424,7 +1424,6 @@ pub const cpu = struct {
.clwb, .clwb,
.cmov, .cmov,
.cmpccxadd, .cmpccxadd,
.crc32,
.cx16, .cx16,
.enqcmd, .enqcmd,
.f16c, .f16c,
@ -1500,7 +1499,6 @@ pub const cpu = struct {
.clwb, .clwb,
.cmov, .cmov,
.cmpccxadd, .cmpccxadd,
.crc32,
.cx16, .cx16,
.enqcmd, .enqcmd,
.f16c, .f16c,
@ -1735,7 +1733,6 @@ pub const cpu = struct {
.aes, .aes,
.clflushopt, .clflushopt,
.cmov, .cmov,
.crc32,
.cx16, .cx16,
.false_deps_popcnt, .false_deps_popcnt,
.fast_7bytenop, .fast_7bytenop,
@ -1799,7 +1796,6 @@ pub const cpu = struct {
.aes, .aes,
.branchfusion, .branchfusion,
.cmov, .cmov,
.crc32,
.cx16, .cx16,
.fast_11bytenop, .fast_11bytenop,
.fast_scalar_shift_masks, .fast_scalar_shift_masks,
@ -1830,7 +1826,6 @@ pub const cpu = struct {
.bmi, .bmi,
.branchfusion, .branchfusion,
.cmov, .cmov,
.crc32,
.cx16, .cx16,
.f16c, .f16c,
.fast_11bytenop, .fast_11bytenop,
@ -1866,7 +1861,6 @@ pub const cpu = struct {
.bmi, .bmi,
.branchfusion, .branchfusion,
.cmov, .cmov,
.crc32,
.cx16, .cx16,
.f16c, .f16c,
.fast_11bytenop, .fast_11bytenop,
@ -1905,7 +1899,6 @@ pub const cpu = struct {
.bmi2, .bmi2,
.branchfusion, .branchfusion,
.cmov, .cmov,
.crc32,
.cx16, .cx16,
.f16c, .f16c,
.fast_11bytenop, .fast_11bytenop,
@ -1973,7 +1966,6 @@ pub const cpu = struct {
.bmi, .bmi,
.bmi2, .bmi2,
.cmov, .cmov,
.crc32,
.cx16, .cx16,
.ermsb, .ermsb,
.f16c, .f16c,
@ -2043,7 +2035,6 @@ pub const cpu = struct {
.aes, .aes,
.bmi, .bmi,
.cmov, .cmov,
.crc32,
.cx16, .cx16,
.f16c, .f16c,
.fast_15bytenop, .fast_15bytenop,
@ -2113,7 +2104,6 @@ pub const cpu = struct {
.bmi2, .bmi2,
.clflushopt, .clflushopt,
.cmov, .cmov,
.crc32,
.cx16, .cx16,
.ermsb, .ermsb,
.evex512, .evex512,
@ -2172,7 +2162,6 @@ pub const cpu = struct {
.clflushopt, .clflushopt,
.clwb, .clwb,
.cmov, .cmov,
.crc32,
.cx16, .cx16,
.ermsb, .ermsb,
.evex512, .evex512,
@ -2233,7 +2222,6 @@ pub const cpu = struct {
.clwb, .clwb,
.cmov, .cmov,
.cmpccxadd, .cmpccxadd,
.crc32,
.cx16, .cx16,
.enqcmd, .enqcmd,
.f16c, .f16c,
@ -2313,7 +2301,6 @@ pub const cpu = struct {
.clflushopt, .clflushopt,
.clwb, .clwb,
.cmov, .cmov,
.crc32,
.cx16, .cx16,
.ermsb, .ermsb,
.evex512, .evex512,
@ -2379,7 +2366,6 @@ pub const cpu = struct {
.features = featureSet(&[_]Feature{ .features = featureSet(&[_]Feature{
.@"64bit", .@"64bit",
.cmov, .cmov,
.crc32,
.cx16, .cx16,
.fxsr, .fxsr,
.idivq_to_divl, .idivq_to_divl,
@ -2419,7 +2405,6 @@ pub const cpu = struct {
.clflushopt, .clflushopt,
.clwb, .clwb,
.cmov, .cmov,
.crc32,
.cx16, .cx16,
.enqcmd, .enqcmd,
.ermsb, .ermsb,
@ -2514,7 +2499,6 @@ pub const cpu = struct {
.aes, .aes,
.clflushopt, .clflushopt,
.cmov, .cmov,
.crc32,
.cx16, .cx16,
.false_deps_popcnt, .false_deps_popcnt,
.fast_imm16, .fast_imm16,
@ -2552,7 +2536,6 @@ pub const cpu = struct {
.aes, .aes,
.clflushopt, .clflushopt,
.cmov, .cmov,
.crc32,
.cx16, .cx16,
.fast_imm16, .fast_imm16,
.fast_movbe, .fast_movbe,
@ -2596,7 +2579,6 @@ pub const cpu = struct {
.clflushopt, .clflushopt,
.clwb, .clwb,
.cmov, .cmov,
.crc32,
.cx16, .cx16,
.f16c, .f16c,
.false_deps_popcnt, .false_deps_popcnt,
@ -2658,7 +2640,6 @@ pub const cpu = struct {
.clwb, .clwb,
.cmov, .cmov,
.cmpccxadd, .cmpccxadd,
.crc32,
.cx16, .cx16,
.enqcmd, .enqcmd,
.f16c, .f16c,
@ -2732,7 +2713,6 @@ pub const cpu = struct {
.clflushopt, .clflushopt,
.clwb, .clwb,
.cmov, .cmov,
.crc32,
.cx16, .cx16,
.enqcmd, .enqcmd,
.ermsb, .ermsb,
@ -2821,7 +2801,6 @@ pub const cpu = struct {
.clflushopt, .clflushopt,
.clwb, .clwb,
.cmov, .cmov,
.crc32,
.cx16, .cx16,
.enqcmd, .enqcmd,
.ermsb, .ermsb,
@ -2892,7 +2871,6 @@ pub const cpu = struct {
.bmi, .bmi,
.bmi2, .bmi2,
.cmov, .cmov,
.crc32,
.cx16, .cx16,
.ermsb, .ermsb,
.f16c, .f16c,
@ -2984,7 +2962,6 @@ pub const cpu = struct {
.bmi2, .bmi2,
.clflushopt, .clflushopt,
.cmov, .cmov,
.crc32,
.cx16, .cx16,
.ermsb, .ermsb,
.evex512, .evex512,
@ -3049,7 +3026,6 @@ pub const cpu = struct {
.clflushopt, .clflushopt,
.clwb, .clwb,
.cmov, .cmov,
.crc32,
.cx16, .cx16,
.ermsb, .ermsb,
.evex512, .evex512,
@ -3101,7 +3077,6 @@ pub const cpu = struct {
.features = featureSet(&[_]Feature{ .features = featureSet(&[_]Feature{
.@"64bit", .@"64bit",
.cmov, .cmov,
.crc32,
.cx16, .cx16,
.f16c, .f16c,
.false_deps_popcnt, .false_deps_popcnt,
@ -3214,7 +3189,6 @@ pub const cpu = struct {
.bmi, .bmi,
.bmi2, .bmi2,
.cmov, .cmov,
.crc32,
.cx16, .cx16,
.evex512, .evex512,
.fast_gather, .fast_gather,
@ -3257,7 +3231,6 @@ pub const cpu = struct {
.bmi, .bmi,
.bmi2, .bmi2,
.cmov, .cmov,
.crc32,
.cx16, .cx16,
.evex512, .evex512,
.fast_gather, .fast_gather,
@ -3315,7 +3288,6 @@ pub const cpu = struct {
.clwb, .clwb,
.cmov, .cmov,
.cmpccxadd, .cmpccxadd,
.crc32,
.cx16, .cx16,
.enqcmd, .enqcmd,
.f16c, .f16c,
@ -3389,7 +3361,6 @@ pub const cpu = struct {
.clflushopt, .clflushopt,
.clwb, .clwb,
.cmov, .cmov,
.crc32,
.cx16, .cx16,
.f16c, .f16c,
.false_deps_perm, .false_deps_perm,
@ -3450,7 +3421,6 @@ pub const cpu = struct {
.features = featureSet(&[_]Feature{ .features = featureSet(&[_]Feature{
.@"64bit", .@"64bit",
.cmov, .cmov,
.crc32,
.cx16, .cx16,
.fxsr, .fxsr,
.idivq_to_divl, .idivq_to_divl,
@ -3540,7 +3510,6 @@ pub const cpu = struct {
.clwb, .clwb,
.cmov, .cmov,
.cmpccxadd, .cmpccxadd,
.crc32,
.cx16, .cx16,
.enqcmd, .enqcmd,
.f16c, .f16c,
@ -3755,7 +3724,6 @@ pub const cpu = struct {
.clflushopt, .clflushopt,
.clwb, .clwb,
.cmov, .cmov,
.crc32,
.cx16, .cx16,
.f16c, .f16c,
.false_deps_perm, .false_deps_perm,
@ -3830,7 +3798,6 @@ pub const cpu = struct {
.bmi2, .bmi2,
.clflushopt, .clflushopt,
.cmov, .cmov,
.crc32,
.cx16, .cx16,
.ermsb, .ermsb,
.evex512, .evex512,
@ -3881,7 +3848,6 @@ pub const cpu = struct {
.@"64bit", .@"64bit",
.avx, .avx,
.cmov, .cmov,
.crc32,
.cx16, .cx16,
.false_deps_popcnt, .false_deps_popcnt,
.fast_15bytenop, .fast_15bytenop,
@ -3928,7 +3894,6 @@ pub const cpu = struct {
.clflushopt, .clflushopt,
.clwb, .clwb,
.cmov, .cmov,
.crc32,
.cx16, .cx16,
.enqcmd, .enqcmd,
.ermsb, .ermsb,
@ -4005,7 +3970,6 @@ pub const cpu = struct {
.clwb, .clwb,
.cmov, .cmov,
.cmpccxadd, .cmpccxadd,
.crc32,
.cx16, .cx16,
.enqcmd, .enqcmd,
.f16c, .f16c,
@ -4058,7 +4022,6 @@ pub const cpu = struct {
.features = featureSet(&[_]Feature{ .features = featureSet(&[_]Feature{
.@"64bit", .@"64bit",
.cmov, .cmov,
.crc32,
.cx16, .cx16,
.false_deps_popcnt, .false_deps_popcnt,
.fast_7bytenop, .fast_7bytenop,
@ -4102,7 +4065,6 @@ pub const cpu = struct {
.clflushopt, .clflushopt,
.clwb, .clwb,
.cmov, .cmov,
.crc32,
.cx16, .cx16,
.ermsb, .ermsb,
.evex512, .evex512,
@ -4157,7 +4119,6 @@ pub const cpu = struct {
.bmi2, .bmi2,
.clflushopt, .clflushopt,
.cmov, .cmov,
.crc32,
.cx16, .cx16,
.ermsb, .ermsb,
.f16c, .f16c,
@ -4213,7 +4174,6 @@ pub const cpu = struct {
.clflushopt, .clflushopt,
.clwb, .clwb,
.cmov, .cmov,
.crc32,
.cx16, .cx16,
.ermsb, .ermsb,
.evex512, .evex512,
@ -4261,7 +4221,6 @@ pub const cpu = struct {
.features = featureSet(&[_]Feature{ .features = featureSet(&[_]Feature{
.@"64bit", .@"64bit",
.cmov, .cmov,
.crc32,
.cx16, .cx16,
.false_deps_popcnt, .false_deps_popcnt,
.fast_7bytenop, .fast_7bytenop,
@ -4310,7 +4269,6 @@ pub const cpu = struct {
.clflushopt, .clflushopt,
.clwb, .clwb,
.cmov, .cmov,
.crc32,
.cx16, .cx16,
.ermsb, .ermsb,
.evex512, .evex512,
@ -4366,7 +4324,6 @@ pub const cpu = struct {
.clflushopt, .clflushopt,
.clwb, .clwb,
.cmov, .cmov,
.crc32,
.cx16, .cx16,
.fast_imm16, .fast_imm16,
.fast_movbe, .fast_movbe,
@ -4404,7 +4361,6 @@ pub const cpu = struct {
.features = featureSet(&[_]Feature{ .features = featureSet(&[_]Feature{
.@"64bit", .@"64bit",
.cmov, .cmov,
.crc32,
.cx16, .cx16,
.fxsr, .fxsr,
.idivq_to_divl, .idivq_to_divl,
@ -4466,7 +4422,6 @@ pub const cpu = struct {
.features = featureSet(&[_]Feature{ .features = featureSet(&[_]Feature{
.@"64bit", .@"64bit",
.cmov, .cmov,
.crc32,
.cx16, .cx16,
.false_deps_popcnt, .false_deps_popcnt,
.fast_15bytenop, .fast_15bytenop,
@ -4496,7 +4451,6 @@ pub const cpu = struct {
.bmi, .bmi,
.bmi2, .bmi2,
.cmov, .cmov,
.crc32,
.cx16, .cx16,
.f16c, .f16c,
.false_deps_lzcnt_tzcnt, .false_deps_lzcnt_tzcnt,
@ -4535,7 +4489,6 @@ pub const cpu = struct {
.bmi, .bmi,
.bmi2, .bmi2,
.cmov, .cmov,
.crc32,
.cx16, .cx16,
.evex512, .evex512,
.false_deps_popcnt, .false_deps_popcnt,
@ -4592,7 +4545,6 @@ pub const cpu = struct {
.clflushopt, .clflushopt,
.clzero, .clzero,
.cmov, .cmov,
.crc32,
.cx16, .cx16,
.f16c, .f16c,
.fast_15bytenop, .fast_15bytenop,
@ -4646,7 +4598,6 @@ pub const cpu = struct {
.clwb, .clwb,
.clzero, .clzero,
.cmov, .cmov,
.crc32,
.cx16, .cx16,
.f16c, .f16c,
.fast_15bytenop, .fast_15bytenop,
@ -4701,7 +4652,6 @@ pub const cpu = struct {
.clwb, .clwb,
.clzero, .clzero,
.cmov, .cmov,
.crc32,
.cx16, .cx16,
.f16c, .f16c,
.fast_15bytenop, .fast_15bytenop,
@ -4771,7 +4721,6 @@ pub const cpu = struct {
.clwb, .clwb,
.clzero, .clzero,
.cmov, .cmov,
.crc32,
.cx16, .cx16,
.evex512, .evex512,
.fast_15bytenop, .fast_15bytenop,
@ -4845,7 +4794,6 @@ pub const cpu = struct {
.clwb, .clwb,
.clzero, .clzero,
.cmov, .cmov,
.crc32,
.cx16, .cx16,
.evex512, .evex512,
.fast_15bytenop, .fast_15bytenop,

4
tools/update_cpu_features.zig
View file

@ -1139,6 +1139,10 @@ const llvm_targets = [_]LlvmTarget{
.llvm_name = "winchip2", .llvm_name = "winchip2",
.extra_deps = &.{"3dnow"}, .extra_deps = &.{"3dnow"},
}, },
.{
.llvm_name = "sse4.2",
.extra_deps = &.{"crc32"},
},
}, },
// Features removed from LLVM // Features removed from LLVM
.extra_features = &.{ .extra_features = &.{