mirrors/zig
1
0
Fork 0
mirror of https://codeberg.org/ziglang/zig.git synced 2025-12-06 13:54:21 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

AstGen: require binary operations to have reachable operands

Browse source
This commit is contained in:
Andrew Kelley 2021-11-29 13:21:36 -07:00
parent b613210140
commit d3426ce634
2 changed files with 8 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/AstGen.zig
View file

@ -4781,8 +4781,8 @@ fn simpleBinOp(
const node_datas = tree.nodes.items(.data); const node_datas = tree.nodes.items(.data);
const result = try gz.addPlNode(op_inst_tag, node, Zir.Inst.Bin{ const result = try gz.addPlNode(op_inst_tag, node, Zir.Inst.Bin{
.lhs = try expr(gz, scope, .none, node_datas[node].lhs), .lhs = try reachableExpr(gz, scope, .none, node_datas[node].lhs, node),
.rhs = try expr(gz, scope, .none, node_datas[node].rhs), .rhs = try reachableExpr(gz, scope, .none, node_datas[node].rhs, node),
}); });
return rvalue(gz, rl, result, node); return rvalue(gz, rl, result, node);
} }

7
test/compile_errors.zig
View file

@ -5033,13 +5033,18 @@ pub fn addCases(ctx: *TestContext) !void {
"tmp.zig:2:5: note: control flow is diverted here", "tmp.zig:2:5: note: control flow is diverted here",
}); });
ctx.objErrStage1("unreachable code - return return", ctx.objErrStage1("unreachable code - multiple things",
\\export fn a() i32 { \\export fn a() i32 {
\\ return return 1; \\ return return 1;
\\} \\}
\\export fn b(value: u32) bool {
\\ return 1 < value < 1000;
\\}
, &[_][]const u8{ , &[_][]const u8{
"tmp.zig:2:5: error: unreachable code", "tmp.zig:2:5: error: unreachable code",
"tmp.zig:2:12: note: control flow is diverted here", "tmp.zig:2:12: note: control flow is diverted here",
"tmp.zig:5:22: error: unreachable code",
"tmp.zig:5:5: note: control flow is diverted here",
}); });
ctx.objErrStage1("bad import", ctx.objErrStage1("bad import",