mirrors/zig
1
0
Fork 0
mirror of https://codeberg.org/ziglang/zig.git synced 2025-12-06 13:54:21 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

std.Build.Step.CheckObject: fix the TODO

Browse source
This commit is contained in:
Andrew Kelley 2025-07-01 08:44:26 -07:00
parent 87f32bec26
commit d6ac04c478
1 changed files with 4 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
lib/std/Build/Step/CheckObject.zig
View file

@ -1352,7 +1352,7 @@ const MachODumper = struct {
var offset: u64 = 0; var offset: u64 = 0;
var addend: i64 = 0; var addend: i64 = 0;
var name_buf: std.ArrayList(u8) = .init(ctx.gpa); var name_buf: std.io.Writer.Allocating = .init(ctx.gpa);
defer name_buf.deinit(); defer name_buf.deinit();
while (br.takeByte()) |byte| { while (br.takeByte()) |byte| {
@ -1380,9 +1380,8 @@ const MachODumper = struct {
}, },
macho.BIND_OPCODE_SET_SYMBOL_TRAILING_FLAGS_IMM => { macho.BIND_OPCODE_SET_SYMBOL_TRAILING_FLAGS_IMM => {
name_buf.clearRetainingCapacity(); name_buf.clearRetainingCapacity();
if (true) @panic("TODO fix this"); try br.streamDelimiterLimit(&name_buf, 0, .limited(std.math.maxInt(u32)));
//try reader.readUntilDelimiterArrayList(&name_buf, 0, std.math.maxInt(u32)); try name_buf.writeByte(0);
try name_buf.append(0);
}, },
macho.BIND_OPCODE_SET_ADDEND_SLEB => { macho.BIND_OPCODE_SET_ADDEND_SLEB => {
addend = try br.takeLeb128(i64); addend = try br.takeLeb128(i64);
@ -1424,7 +1423,7 @@ const MachODumper = struct {
.addend = addend, .addend = addend,
.tag = tag, .tag = tag,
.ordinal = ordinal, .ordinal = ordinal,
.name = try ctx.gpa.dupe(u8, name_buf.items), .name = try ctx.gpa.dupe(u8, name_buf.getWritten()),
}); });
offset += skip + @sizeOf(u64) + add_addr; offset += skip + @sizeOf(u64) + add_addr;
} }