Merge pull request #23011 from alexrp/macho-cu-intcast

`link.MachO.UnwindInfo`: Handle `u24` overflow for CU records pointing to DWARF.
This commit is contained in:
Andrew Kelley 2025-02-25 14:19:36 -05:00 committed by GitHub
commit e902c231c8
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -68,7 +68,18 @@ pub fn generate(info: *UnwindInfo, macho_file: *MachO) !void {
for (info.records.items) |ref| {
const rec = ref.getUnwindRecord(macho_file);
if (rec.getFde(macho_file)) |fde| {
rec.enc.setDwarfSectionOffset(@intCast(fde.out_offset));
// The unwinder will look for the DWARF entry starting at the hint,
// assuming the hint points to a valid CFI record start. If it
// fails to find the record, it proceeds in a linear search through
// the contiguous CFI records from the hint until the end of the
// section. Ideally, in the case where the offset is too large to
// be encoded, we would instead encode the largest possible offset
// to a valid CFI record, but since we don't keep track of that,
// just encode zero -- the start of the section is always the start
// of a CFI record.
const hint = std.math.cast(u24, fde.out_offset) orelse 0;
rec.enc.setDwarfSectionOffset(hint);
if (fde.getLsdaAtom(macho_file)) |lsda| {
rec.lsda = lsda.atom_index;
rec.lsda_offset = fde.lsda_offset;