From e9ae9a5fc45a6ee85d988372a4d150032f52ef4c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alex=20R=C3=B8nne=20Petersen?= Date: Thu, 31 Oct 2024 09:00:46 +0100 Subject: [PATCH] llvm: Don't set nonnull attribute on allowzero slices. --- src/codegen/llvm.zig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/codegen/llvm.zig b/src/codegen/llvm.zig index 0c6aaa66fb..0bbc3aee46 100644 --- a/src/codegen/llvm.zig +++ b/src/codegen/llvm.zig @@ -1341,7 +1341,7 @@ pub const Object = struct { try attributes.addParamAttr(llvm_arg_i, .@"noalias", &o.builder); } } - if (param_ty.zigTypeTag(zcu) != .optional) { + if (param_ty.zigTypeTag(zcu) != .optional and !ptr_info.flags.is_allowzero) { try attributes.addParamAttr(llvm_arg_i, .nonnull, &o.builder); } if (ptr_info.flags.is_const) { @@ -5410,7 +5410,7 @@ pub const FuncGen = struct { try attributes.addParamAttr(llvm_arg_i, .@"noalias", &o.builder); } } - if (param_ty.zigTypeTag(zcu) != .optional) { + if (param_ty.zigTypeTag(zcu) != .optional and !ptr_info.flags.is_allowzero) { try attributes.addParamAttr(llvm_arg_i, .nonnull, &o.builder); } if (ptr_info.flags.is_const) {