From fe855691f6f742a14678cb617422977c2a55be39 Mon Sep 17 00:00:00 2001 From: mlugg Date: Wed, 21 May 2025 01:45:05 +0100 Subject: [PATCH] std.Build.Step.Run: inherit build runner cwd Right now, if you override the build root with `--build-root`, then `Run` steps can fail to execute because of incorrect path handling in the compiler: `std.process.Child` gets a cwd-relative path, but also has its cwd set to the build root. The latter behavior is really weird; it doesn't match my expectations, nor does it match how we spawn child `zig` processes. So, this commit makes the child process inherit the build runner's cwd, as `LazyPath.getPath2` *expects* it to. After investigating, this behavior dates all the way back to 2017; it was introduced in 4543413. So, there isn't any clear/documented reason for this; it should be safe to revert, since under the modern `LazyPath` system it is strictly a bug AFAICT. --- lib/std/Build/Step/Run.zig | 3 --- 1 file changed, 3 deletions(-) diff --git a/lib/std/Build/Step/Run.zig b/lib/std/Build/Step/Run.zig index eede464ab6..b7ad1307fb 100644 --- a/lib/std/Build/Step/Run.zig +++ b/lib/std/Build/Step/Run.zig @@ -1334,9 +1334,6 @@ fn spawnChildAndCollect( var child = std.process.Child.init(argv, arena); if (run.cwd) |lazy_cwd| { child.cwd = lazy_cwd.getPath2(b, &run.step); - } else { - child.cwd = b.build_root.path; - child.cwd_dir = b.build_root.handle; } child.env_map = run.env_map orelse &b.graph.env_map; child.request_resource_usage_statistics = true;