zig/lib/std/posix at incr-bug - mirrors/zig - "Borealis" Git by INX: Hosted by INX "Xenon".

mirror of https://codeberg.org/ziglang/zig.git synced 2025-12-06 13:54:21 +00:00

History

Pat Tullmann 4d6429fc4f POSIX link() syscall only takes two arguments (no flags) The signature is documented as: int link(const char , const char ); (see https://man7.org/linux/man-pages/man2/link.2.html or https://man.netbsd.org/link.2) And its not some Linux extension, the [syscall implementation](`21b136cc63/fs/namei.c (L4794-L4797)`) only expects two arguments too. It probably should have a flags parameter, but its too late now. I am a bit surprised that linking glibc or musl against code that invokes a 'link' with three parameters doesn't fail (at least, I couldn't get any local test cases to trigger a compile or link error). The test case in std/posix/test.zig is currently disabled, but if I manually enable it, it works with this change.	2024-08-07 13:05:42 -07:00
..
test.zig	POSIX link() syscall only takes two arguments (no flags)	2024-08-07 13:05:42 -07:00

Pat Tullmann 4d6429fc4f POSIX link() syscall only takes two arguments (no flags)

The signature is documented as:

   int link(const char *, const char *);

(see https://man7.org/linux/man-pages/man2/link.2.html or https://man.netbsd.org/link.2)

And its not some Linux extension, the [syscall
implementation](21b136cc63/fs/namei.c (L4794-L4797))
only expects two arguments too.

It probably *should* have a flags parameter, but its too late now.

I am a bit surprised that linking glibc or musl against code that invokes
a 'link' with three parameters doesn't fail (at least, I couldn't get any
local test cases to trigger a compile or link error).

The test case in std/posix/test.zig is currently disabled, but if I
manually enable it, it works with this change.

2024-08-07 13:05:42 -07:00

test.zig POSIX link() syscall only takes two arguments (no flags) 2024-08-07 13:05:42 -07:00