Niles Salter 7d511d6428 [heapsort] Protect against integer overflow ... (Firstly, I changed `n` to `b`, as that is less confusing. It's not a length, it's a right boundary.) The invariant maintained is `cur < b`. In the worst case `2*cur + 1` results in a maximum of `2b`. Since `2b` is not guaranteed to be lower than `maxInt`, we have to add one overflow check to `siftDown` to make sure we avoid undefined behavior. LLVM also seems to have a nicer time compiling this version of the function. It is about 2x faster in my tests (I think LLVM was stumped by the `child += @intFromBool` line), and adding/removing the overflow check has a negligible performance difference on my machine. Of course, we could check `2b <= maxInt` in the parent function, and dispatch to a version of the function without the overflow check in the common case, but that probably is not worth the code size just to eliminate a single instruction.		2023-06-22 17:32:28 +00:00
..
atomic	all: zig fmt and rename "@XToY" to "@YFromX"	2023-06-19 12:34:42 -07:00
Build	all: zig fmt and rename "@XToY" to "@YFromX"	2023-06-19 12:34:42 -07:00
c	std.c: update netbsd/openbsd mman constants	2023-06-22 10:21:48 +00:00
compress	all: zig fmt and rename "@XToY" to "@YFromX"	2023-06-19 12:34:42 -07:00
crypto	all: zig fmt and rename "@XToY" to "@YFromX"	2023-06-19 12:34:42 -07:00
dwarf
event	all: zig fmt and rename "@XToY" to "@YFromX"	2023-06-19 12:34:42 -07:00
fmt	all: zig fmt and rename "@XToY" to "@YFromX"	2023-06-19 12:34:42 -07:00
fs	all: zig fmt and rename "@XToY" to "@YFromX"	2023-06-19 12:34:42 -07:00
hash	all: zig fmt and rename "@XToY" to "@YFromX"	2023-06-19 12:34:42 -07:00
heap	all: zig fmt and rename "@XToY" to "@YFromX"	2023-06-19 12:34:42 -07:00
http	http: fix getting Transfer-Encoding value	2023-06-22 11:44:46 +03:00
io	rename ZIG_DEBUG_COLOR env variable to YES_COLOR	2023-06-22 10:29:45 +10:00
json	std: json.parseFromValue() (#15981)	2023-06-20 19:01:34 -04:00
math	all: zig fmt and rename "@XToY" to "@YFromX"	2023-06-19 12:34:42 -07:00
mem	all: zig fmt and rename "@XToY" to "@YFromX"	2023-06-19 12:34:42 -07:00
meta	all: zig fmt and rename "@XToY" to "@YFromX"	2023-06-19 12:34:42 -07:00
net	Disallow named test decls with duplicate names	2023-05-08 10:59:06 +03:00
os	all: zig fmt and rename "@XToY" to "@YFromX"	2023-06-19 12:34:42 -07:00
rand	all: zig fmt and rename "@XToY" to "@YFromX"	2023-06-19 12:34:42 -07:00
sort	migration: std.math.{min, min3, max, max3} -> @min & @max	2023-06-16 13:44:09 -07:00
target	all: zig fmt and rename "@XToY" to "@YFromX"	2023-06-19 12:34:42 -07:00
testing	update codebase to use @memset and @memcpy	2023-04-28 13:24:43 -07:00
Thread	std: prevent random CI failures	2023-06-20 10:56:23 -07:00
time	all: zig fmt and rename "@XToY" to "@YFromX"	2023-06-19 12:34:42 -07:00
tz
unicode	all: zig fmt and rename "@XToY" to "@YFromX"	2023-06-19 12:34:42 -07:00
valgrind	all: zig fmt and rename "@XToY" to "@YFromX"	2023-06-19 12:34:42 -07:00
zig	all: zig fmt and rename "@XToY" to "@YFromX"	2023-06-19 12:34:42 -07:00
array_hash_map.zig	all: zig fmt and rename "@XToY" to "@YFromX"	2023-06-19 12:34:42 -07:00
array_list.zig	InternPool: port most of value tags	2023-06-10 20:47:54 -07:00
ascii.zig	migration: std.math.{min, min3, max, max3} -> @min & @max	2023-06-16 13:44:09 -07:00
atomic.zig	std: remove names from incorrectly named tests	2023-04-21 23:08:48 -04:00
base64.zig	all: replace comptime try with try comptime	2023-06-13 23:46:58 +06:00
bit_set.zig	all: zig fmt and rename "@XToY" to "@YFromX"	2023-06-19 12:34:42 -07:00
bounded_array.zig	convert s[start..start+len] to s[start..][0..len]	2023-05-07 15:55:21 +10:00
buf_map.zig	doc: fix minor grammar issues	2023-04-22 13:09:15 +03:00
buf_set.zig	update codebase to use @memset and @memcpy	2023-04-28 13:24:43 -07:00
Build.zig	std: replace builtin.Version with SemanticVersion	2023-06-17 13:17:34 -07:00
builtin.zig	std: replace builtin.Version with SemanticVersion	2023-06-17 13:17:34 -07:00
c.zig	all: zig fmt and rename "@XToY" to "@YFromX"	2023-06-19 12:34:42 -07:00
child_process.zig	all: zig fmt and rename "@XToY" to "@YFromX"	2023-06-19 12:34:42 -07:00
coff.zig	all: zig fmt and rename "@XToY" to "@YFromX"	2023-06-19 12:34:42 -07:00
compress.zig
comptime_string_map.zig	std.sort: add pdqsort and heapsort	2023-05-23 17:55:59 -07:00
crypto.zig	std.crypto.ff - Alloc-free, constant-time field arithmetic for crypto (#15795)	2023-05-22 16:11:06 +02:00
cstr.zig	all: replace comptime try with try comptime	2023-06-13 23:46:58 +06:00
debug.zig	all: zig fmt and rename "@XToY" to "@YFromX"	2023-06-19 12:34:42 -07:00
dwarf.zig	std.dwarf: fix findCompileUnit when ranges offset is given by const	2023-06-12 14:22:45 -07:00
dynamic_library.zig	all: zig fmt and rename "@XToY" to "@YFromX"	2023-06-19 12:34:42 -07:00
elf.zig	Merge pull request #16046 from BratishkaErik/issue-6128	2023-06-19 22:36:24 -07:00
enums.zig	all: zig fmt and rename "@XToY" to "@YFromX"	2023-06-19 12:34:42 -07:00
event.zig
fifo.zig	migration: std.math.{min, min3, max, max3} -> @min & @max	2023-06-16 13:44:09 -07:00
fmt.zig	Merge pull request #16046 from BratishkaErik/issue-6128	2023-06-19 22:36:24 -07:00
fs.zig	all: zig fmt and rename "@XToY" to "@YFromX"	2023-06-19 12:34:42 -07:00
hash.zig	add std.hash.uint32	2023-06-10 20:42:30 -07:00
hash_map.zig	all: zig fmt and rename "@XToY" to "@YFromX"	2023-06-19 12:34:42 -07:00
heap.zig	all: zig fmt and rename "@XToY" to "@YFromX"	2023-06-19 12:34:42 -07:00
http.zig	all: zig fmt and rename "@XToY" to "@YFromX"	2023-06-19 12:34:42 -07:00
Ini.zig
io.zig	all: zig fmt and rename "@XToY" to "@YFromX"	2023-06-19 12:34:42 -07:00
json.zig	std: Support user-provided jsonParse method. Unify json.Parser and json.parse* (#15705)	2023-06-19 11:21:37 -04:00
leb128.zig	all: zig fmt and rename "@XToY" to "@YFromX"	2023-06-19 12:34:42 -07:00
linked_list.zig	std: fix a bunch of typos	2023-04-30 18:16:04 -07:00
log.zig	all: zig fmt and rename "@XToY" to "@YFromX"	2023-06-19 12:34:42 -07:00
macho.zig	std: fix a bunch of typos	2023-04-30 18:16:04 -07:00
math.zig	all: zig fmt and rename "@XToY" to "@YFromX"	2023-06-19 12:34:42 -07:00
mem.zig	all: zig fmt and rename "@XToY" to "@YFromX"	2023-06-19 12:34:42 -07:00
meta.zig	all: zig fmt and rename "@XToY" to "@YFromX"	2023-06-19 12:34:42 -07:00
multi_array_list.zig	all: zig fmt and rename "@XToY" to "@YFromX"	2023-06-19 12:34:42 -07:00
net.zig	all: zig fmt and rename "@XToY" to "@YFromX"	2023-06-19 12:34:42 -07:00
once.zig
os.zig	std.os: update logic for 64-bit symbol choice	2023-06-20 12:55:38 -04:00
packed_int_array.zig	std: fix a bunch of typos	2023-04-30 18:16:04 -07:00
pdb.zig	all: zig fmt and rename "@XToY" to "@YFromX"	2023-06-19 12:34:42 -07:00
priority_dequeue.zig	[priority_dequeue] Fix out-of-bounds access	2023-06-22 02:03:53 -07:00
priority_queue.zig
process.zig	all: zig fmt and rename "@XToY" to "@YFromX"	2023-06-19 12:34:42 -07:00
Progress.zig	update codebase to use @memset and @memcpy	2023-04-28 13:24:43 -07:00
rand.zig	migration: std.math.{min, min3, max, max3} -> @min & @max	2023-06-16 13:44:09 -07:00
RingBuffer.zig	all: zig fmt and rename "@XToY" to "@YFromX"	2023-06-19 12:34:42 -07:00
segmented_list.zig	update codebase to use @memset and @memcpy	2023-04-28 13:24:43 -07:00
SemanticVersion.zig	std: replace builtin.Version with SemanticVersion	2023-06-17 13:17:34 -07:00
simd.zig	all: zig fmt and rename "@XToY" to "@YFromX"	2023-06-19 12:34:42 -07:00
sort.zig	[heapsort] Protect against integer overflow	2023-06-22 17:32:28 +00:00
start.zig	all: zig fmt and rename "@XToY" to "@YFromX"	2023-06-19 12:34:42 -07:00
start_windows_tls.zig	all: zig fmt and rename "@XToY" to "@YFromX"	2023-06-19 12:34:42 -07:00
std.zig	add BoundedArrayAligned (#14580)	2023-03-17 17:50:25 +01:00
tar.zig	all: zig fmt and rename "@XToY" to "@YFromX"	2023-06-19 12:34:42 -07:00
target.zig	std.Target: c_char is unsigned on RISC-V	2023-06-20 08:27:55 -07:00
testing.zig	mem: rename align*Generic to mem.align*	2023-06-17 12:49:13 -07:00
Thread.zig	all: zig fmt and rename "@XToY" to "@YFromX"	2023-06-19 12:34:42 -07:00
time.zig	std: fix a bunch of typos	2023-04-30 18:16:04 -07:00
treap.zig	all: zig fmt and rename "@XToY" to "@YFromX"	2023-06-19 12:34:42 -07:00
tz.zig	update codebase to use @memset and @memcpy	2023-04-28 13:24:43 -07:00
unicode.zig	all: replace comptime try with try comptime	2023-06-13 23:46:58 +06:00
Uri.zig	migration: std.math.{min, min3, max, max3} -> @min & @max	2023-06-16 13:44:09 -07:00
valgrind.zig	all: zig fmt and rename "@XToY" to "@YFromX"	2023-06-19 12:34:42 -07:00
wasm.zig	all: zig fmt and rename "@XToY" to "@YFromX"	2023-06-19 12:34:42 -07:00
zig.zig	std: replace builtin.Version with SemanticVersion	2023-06-17 13:17:34 -07:00